incubator-devlake icon indicating copy to clipboard operation
incubator-devlake copied to clipboard

feat: embeddable config-ui

Open mintsweet opened this issue 3 years ago • 4 comments

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • [ ] I have read through the Contributing Documentation.
  • [ ] I have added relevant tests.
  • [ ] I have added relevant documentation.
  • [ ] I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

Does this close any open issues?

Closes https://github.com/apache/incubator-devlake/issues/2241

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

mintsweet avatar Sep 15 '22 07:09 mintsweet

thanks for your pr. @e2corporation can you help for review it?

mappjzc avatar Sep 15 '22 14:09 mappjzc

thanks for your pr. @e2corporation can you help for review it?

@mappjzc I'm not sure about this ticket Embeddable UI is not something we've discussed or approved in any recent meetings for this milestone. This looks like a foreign addition to this stack.

e2corporation avatar Sep 15 '22 18:09 e2corporation

@mappjzc This seems like a separate UI project, why is it bundled with incubator-devlake project and not a new standalone project?

e2corporation avatar Sep 15 '22 18:09 e2corporation

@mappjzc This seems like a separate UI project, why is it bundled with incubator-devlake project and not a new standalone project?

@e2corporation This is not my submitted pr. Maybe you would better to communicate with the creator of this pr ?

mappjzc avatar Sep 16 '22 01:09 mappjzc

on hold, to be continued

klesh avatar Nov 23 '22 06:11 klesh

This attempt will be suspended, and at the same time, because the code is much behind, it will turn off it.

mintsweet avatar Mar 16 '23 05:03 mintsweet