perf: added error handling missing code

Open Pranshu-Raj opened this issue 3 years ago • 1 comments

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

[x] I have read through the Contributing Documentation & PR Template
[x] This PR is using a label (bug, feature etc.)
[x] My code is has necessary documentation (if appropriate)
[x] I have added any relevant tests
[x] This section (⚠️ Pre Checklist) will be removed when submitting PR

Summary

Added error handling missing code in gitlab/api/connections.go (GET /plugins/gitlab/connections/:connectionId) Added error handling missing code in gitlab/jenkins/connections.go (GET /plugins/jenkins/connections/:connectionId) Added error handling missing code in gitlab/jira/connections.go (GET /plugins/jira/connections/:connectionId) Added error handling missing code in gitlab/tapd/connections.go (GET /plugins/tapd/connections/:connectionId)

Does this close any open issues?

[Refactor][gitlab,jira,jenkins,tapd] Missing error handling #2561

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

Jul 21 '22 05:07 Pranshu-Raj

Whether error is empty or not, error is returned. So we don't need to make "err ! = nil" judgment before this.

Jul 22 '22 01:07 mappjzc