incubator-brooklyn icon indicating copy to clipboard operation
incubator-brooklyn copied to clipboard

Generate config/effector descriptions for yaml-only blueprints

Open ivanayov opened this issue 9 years ago • 6 comments

ivanayov avatar Jan 27 '16 09:01 ivanayov

LGTM.

One comment though. This generate a JS file which encapsulates the JSON data into a JS var. While this is ok for the documentation as it imports the file directly, it's a bit tedious to share the info with other services (i.e. community catalog) as we will need to eval this file to get the data. I know it was not introduced by this PR but would it be better to get this opportunity to change the format from JS to JSON?

tbouron avatar Jan 27 '16 09:01 tbouron

Jenkins fails due to DynamicSequentialTaskTest.testCancelled which is not related to the issue. The test is successful locally.

ivanayov avatar Jan 28 '16 15:01 ivanayov

@tbouron @neykov if you had noticed docs were loading from a json file for a while. However I noticed the experience wasn't so smooth on production and reverted it back. When it is js file in the html it is automatically cached by the browser with no extra code. https://github.com/apache/incubator-brooklyn/pull/622

bostko avatar Jan 29 '16 08:01 bostko

@bostko Didn't notice that. Let's not reintroduce a slow process then.

However, I quite like the @iyovcheva's idea of generate the JS and JSON file. That will be much more safer and easier for the community catalog :)

tbouron avatar Jan 29 '16 15:01 tbouron

test failure is clearly unrelated, maybe close and reopen to run again.

meanwhile we should look at this /cc @aledsage :

org.apache.brooklyn.entity.software.base.test.autoscaling.AutoScalerPolicyNoMoreMachinesTest.testResizeDirectly (from TestSuite)

java.lang.AssertionError: removed=[EmptySoftwareProcessImpl{id=NhzxGta6}] expected [2] but found [1]
    at org.testng.Assert.fail(Assert.java:94)
    at org.testng.Assert.failNotEquals(Assert.java:494)
    at org.testng.Assert.assertEquals(Assert.java:123)
    at org.testng.Assert.assertEquals(Assert.java:370)
    at org.apache.brooklyn.entity.software.base.test.autoscaling.AutoScalerPolicyNoMoreMachinesTest.assertSize(AutoScalerPolicyNoMoreMachinesTest.java:182)
    at org.apache.brooklyn.entity.software.base.test.autoscaling.AutoScalerPolicyNoMoreMachinesTest.testResizeDirectly(AutoScalerPolicyNoMoreMachinesTest.java:105)

ahgittin avatar Jan 29 '16 20:01 ahgittin

(easily fixed - the test was doing an immediate assert on something happening in another thread; PR to follow; @iyovcheva give it an hour or so for the other fix to land then please close+reopen this to run the jenkins tests again)

ahgittin avatar Jan 29 '16 23:01 ahgittin