incubator-answer
incubator-answer copied to clipboard
apache
Unable to attach a Particular tag to a question - it getting override to different TAG
Describe the bug
Check video
https://github.com/apache/incubator-answer/assets/9161543/67a137b6-a0c4-410a-8a87-dc6689a1ea2f
To Reproduce
Steps to reproduce the behavior:
- Go to '...'
- Click on '....'
- Scroll down to '....'
- See error
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots or video to help explain your problem.
Platform
- Device: [e.g. Desktop, Mobile]
- OS: [e.g. macOS]
- Browser and version: [e.g. Chrome, Safari]
- Version: [e.g. v1.2.0]
@surapuramakhil Thanks for feedback. This is may because did not format the slug name when updating the tags. PUT /tag API. Regular the tag slug name should not have spaces, and spaces will be replaced with a hyphen.
Ah, It's interesting. I checked slug data of these tags. Surprised, only this slug has spaces instead of -. Wondering why had happened.
Thanks, @LinkinStars. Based on information provided, I was able to clean up tags and the issue has been fixed after cleanup.
Hello I would like to take a crack at this bug. @LinkinStars what would be the ideal behaviour in this case?
Hello I would like to take a crack at this bug. @LinkinStars what would be the ideal behaviour in this case?
@prithvidasgupta Good. Let me describe the problem indetail.
In /tag POST API service, the one used to add a tag, you can see that there is formatting for the tag's slug_name. https://github.com/apache/incubator-answer/blob/8670e332345136422a580d661d7ee47a67f284cb/internal/service/tag_common/tag_common.go#L324-L325
In /tag PUT API service, the one used to update the tag, you can see that there is no formatting. https://github.com/apache/incubator-answer/blob/8670e332345136422a580d661d7ee47a67f284cb/internal/service/tag_common/tag_common.go#L822
So, just add the same formatting code to the PUT API service.
BTW, the SlugName should be slugName. You can fix the typo at the same time.
@LinkinStars #923 should be the exact code change as you suggested. I tested it by running the build locally but I am not sure where to add the unit-tests.