incubator-answer
incubator-answer copied to clipboard
No error message is showing in UI - when user update comment and comment exceeds comment max length
Describe the bug
Comment update doesn't save when comment length exceeds its limits. No error message is showing in UI
On Inspect: 400 Bad Request is returned when comment size exceeds its max length.
Suggestion
To show error message - maximum comment size in error pop.
To Reproduce
Steps to reproduce the behavior:
- Go to '...'
- Click on '....'
- Scroll down to '....'
- See error
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots or video to help explain your problem.
Platform
- Device: [e.g. Desktop, Mobile]
- OS: [e.g. macOS]
- Browser and version: [e.g. Chrome, Safari]
- Version: [e.g. v1.2.0]
@surapuramakhil Thanks for the feedback. I'd like to confirm one more thing. Currently, there is actually a error message, but the "original_text" part is not translated. For translation, we will improve this promptly. I'd like to check if you didn't notice the existence of this error message or if you would prefer it to be displayed as a pop-up message?
Ah, this only comment on new comment but doesn't come when users update their comments.
I will update this.
Ah, this only comment on new comment but doesn't come when users update their comments.
Ah, I see, this is indeed a bug.
@LinkinStars can i be assigned?
made a pr. works as expected. https://github.com/apache/incubator-answer/pull/893