incubator-answer icon indicating copy to clipboard operation
incubator-answer copied to clipboard

Admin able to update email of user

Open surapuramakhil opened this issue 11 months ago • 9 comments

Is your enhancement request related to a problem? Please describe

On Explicit requests when user wishes to change email of their account they can request admin to do so.

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

surapuramakhil avatar Mar 15 '24 23:03 surapuramakhil

It appears to be a sub-issue of #346

Octobug avatar Mar 25 '24 04:03 Octobug

@Octobug Yeah I got what you mean. But the deterrence is email serves as user identity (i.e. email ID must be unique) and another difference is user won't be able to do this (I don't recommend users to change their email directly, that's why suggested admin route)

I agree in terms of implementation, its sub-set of a feature.

surapuramakhil avatar Mar 25 '24 10:03 surapuramakhil

@Octobug Yeah I got what you mean. But the deterrence is email serves as user identity (i.e. email ID must be unique) and another difference is user won't be able to do this (I don't recommend users to change their email directly, that's why suggested admin route)

I agree in terms of implementation, its sub-set of a feature.

Yes, this issue does need more consideration. This "Explicit requests" process requires some security mechanism to prove that a request is sent by the true owner of that account. An admin cannot simply change email for a user when he receives a request.

As for #346 , it lets the admin do that change when the admin is confident about the changing. It doesn't involve the aspect of how a user proves who he is.

Octobug avatar Mar 25 '24 11:03 Octobug

This "Explicit requests" process requires some security mechanism to prove that a request is sent by the true owner of that account. An admin cannot simply change email for a user when he receives a request.

@Octobug Ah, I didn't say that you expressed that in https://github.com/apache/incubator-answer/issues/853#issuecomment-2017771967. Even this https://github.com/apache/incubator-answer/issues/853 doesn't involve the aspect of how a user proves who he is.

Email is treated separately as it has more purpose compared to other data like name, profile picture and bio.

surapuramakhil avatar Mar 25 '24 11:03 surapuramakhil

@surapuramakhil I just suddenly realized that there might be security issues in the request process. Sorry to confuse you. 😂

Octobug avatar Mar 25 '24 15:03 Octobug

Admin processing approval process off system. So admin needs to handle security issues :joy: Even today admin can do this by DB udpated. This feature just saves their life.

surapuramakhil avatar Mar 25 '24 15:03 surapuramakhil

Email and username must be unique, modifying the database directly can be dangerous. Add the "Edith profile" menu in Admin -> Users for easy solving.

image

image

fenbox avatar Mar 26 '24 08:03 fenbox

@fenbox I would like to work on this.

Should the end user receive a notification about this? Also, what should be the I8n guidelines for the new text?

prithvidasgupta avatar Apr 28 '24 09:04 prithvidasgupta

@fenbox I would like to work on this.

Should the end user receive a notification about this? Also, what should be the I8n guidelines for the new text?

@prithvidasgupta This feature is an operation where the administrator enforces changes, which can be modified directly. So, there is no need to notify the user or send an email confirmation.

LinkinStars avatar Apr 29 '24 02:04 LinkinStars

Hi @prithvidasgupta, is there any updates on the progress?

fenbox avatar Jun 07 '24 07:06 fenbox

@fenbox I have been busy with interview preparation and didn't get a chance to look at this. I think someone else should pick it up.

prithvidasgupta avatar Jun 07 '24 12:06 prithvidasgupta

@prithvidasgupta It doesn't matter. It's okay.

fenbox avatar Jun 07 '24 12:06 fenbox

Can you assign this to me? @fenbox

sy-records avatar Jun 08 '24 14:06 sy-records