incubator-answer icon indicating copy to clipboard operation
incubator-answer copied to clipboard

Published 20 hours ago • verified publisher icon apache

[Development] make ui exits due to linting error

Open khamui opened this issue 1 year ago • 3 comments

Describe the bug Running make ui exits with a linting error.

To Reproduce Steps to reproduce the behavior:

  1. Run make ui to install frontend locally for development
  2. It will exit due to column length (80)

Expected behavior Should install frontend

Screenshots

Platform (please complete the following information):

  • Device: [e.g. Desktop, Mobile]
  • OS: [e.g. macOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

khamui avatar Jul 08 '23 22:07 khamui

Do you want me to push my fix? I would like to contribute :)

khamui avatar Jul 08 '23 22:07 khamui

Do you want me to push my fix? I would like to contribute :)

We welcome all forms of contributions and look forward to your PRs!

shuashuai avatar Jul 17 '23 02:07 shuashuai

I cannot reproduce this issue on my local system using make ui. I have tried in both dev and in main branch. If this issue has been resolved, please mark this as closed and if possible, please add a link to the PR.

Also running make ui modifies the pnpm-lock.yaml file automatically. I am not sure if this is the expected behavior, or if the lock file should not be versioned.

AdityaMayukhSom avatar Dec 30 '23 20:12 AdityaMayukhSom