ignite icon indicating copy to clipboard operation
ignite copied to clipboard

IGNITE-27033: checkpoint control.sh command

Open DEADripER opened this issue 3 weeks ago • 2 comments

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • [x] There is a single JIRA ticket related to the pull request.
  • [ ] The web-link to the pull request is attached to the JIRA ticket.
  • [ ] The JIRA ticket has the Patch Available state.
  • [ ] The pull request body describes changes that have been made. The description explains WHAT and WHY was made instead of HOW.
  • [ ] The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • [ ] A reviewer has been mentioned through the JIRA comments (see the Maintainers list)
  • [ ] The pull request has been checked by the Teamcity Bot and the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.

DEADripER avatar Dec 01 '25 16:12 DEADripER

@DEADripER please, fix code style violations.

nizhikov avatar Dec 03 '25 07:12 nizhikov

Overall looks good. @DEADripER I wonder, do we support the case when one server node are in-memory and other has pds enabled.

Seems we must just return node status for all cases and print it out like that:

    private static class CheckpointJob extends VisorJob<CheckpointCommandArg, Void> {
...
        @Override protected Void run(CheckpointCommandArg arg) throws IgniteException {
            if (!CU.isPersistenceEnabled(ignite.configuration()))
                return ignite.localNode().id() + ": PDS disabled";
           // checkpoint relate code.
           ....
           if (arg.waitForFinish()) {
               ....
               return ignite.localNode().id() + ": Checkpoint strarted";      
           }
           
           return ignite.localNode().id() + ": Checkpoint finished";
        }

Task must collect node results and return it to the command.

nizhikov avatar Dec 16 '25 11:12 nizhikov