ignite icon indicating copy to clipboard operation
ignite copied to clipboard

IGNITE-22669 Change maven.compiler.source to 11

Open timoninmaxim opened this issue 1 year ago • 2 comments

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • [ ] There is a single JIRA ticket related to the pull request.
  • [ ] The web-link to the pull request is attached to the JIRA ticket.
  • [ ] The JIRA ticket has the Patch Available state.
  • [ ] The pull request body describes changes that have been made. The description explains WHAT and WHY was made instead of HOW.
  • [ ] The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • [ ] A reviewer has been mentioned through the JIRA comments (see the Maintainers list)
  • [ ] The pull request has been checked by the Teamcity Bot and the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.

timoninmaxim avatar Jul 11 '24 15:07 timoninmaxim

If it's a final patch for moving to java 11 we should also:

  • Change ./bin files to check correct java version (11 instead of 8, for example ignite.bat/functions.sh)
  • Remove java-8 profile from tools/pom.xml
  • Remove java8 directory from tools module
  • Change JDK verrsion in all Dockerfiles
  • Change JDK in deb/rpm packages
  • Perhaps clean some code for old java versions (for example, GridCleaner.PRE_JAVA9_CLEANER_CLASS_NAME)
  • Fix cpp/dotnet platforms to use java 11
  • ...

alex-plekhanov avatar Aug 15 '24 07:08 alex-plekhanov

IMAGE 2024-09-03 16:28:44 IMAGE 2024-09-03 16:28:48 IMAGE 2024-09-03 16:28:51

We still have some links to the older java docs. Do we want to fix them?

nizhikov avatar Sep 03 '24 13:09 nizhikov