ignite-3 icon indicating copy to clipboard operation
ignite-3 copied to clipboard

IGNITE-23192 Sql. Arithmetic operations failed with "out of range" exception

Open zstan opened this issue 1 year ago • 2 comments

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

The Review Checklist

  • [ ] Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • [ ] Design: new code conforms with the design principles of the components it is added to.
  • [ ] Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • [ ] Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • [ ] Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

zstan avatar Sep 19 '24 07:09 zstan

@korlov42

  1. I append tests into IgniteTypeSystemTest
  2. Fix IgniteTypeSystem issue
  3. But executions tests already implemented in IGNITE-23141 and just wait this issue to be resolved

zstan avatar Sep 23 '24 14:09 zstan

@korlov42 planner tests extended, check NumericBinaryOperationsTypeCoercionTest -> mathResultMatcher

zstan avatar Sep 25 '24 06:09 zstan