iceberg icon indicating copy to clipboard operation
iceberg copied to clipboard

Add Scan Planning Endpoints to open api spec

Open rahil-c opened this issue 1 year ago • 8 comments

Dev list discussion thread for this change: https://lists.apache.org/thread/flmw1qts0hv8n0k4pd9n1nfry322633y

cc @jackye1995 @rdblue @danielcweeks @nastra @amogh-jahagirdar

Testing

ran make install, make lint, make generate, and python3 rest-catalog-open-api.py

rahil-c avatar Feb 09 '24 21:02 rahil-c

@jackye1995 @rdblue i rebased on the latest changes from https://github.com/apache/iceberg/commit/bb53c3d4e0e27ac6706803c2371793ad2476ae04

Was wondering if you guys can review this when you get a chance.

rahil-c avatar Mar 01 '24 07:03 rahil-c

Was wondering if you guys can also take a look whenever you get a chance appreciate it. cc @danielcweeks, @nastra, @amogh-jahagirdar

rahil-c avatar Mar 16 '24 00:03 rahil-c

@nastra @rdblue @danielcweeks @jackye1995 @amogh-jahagirdar

When looking again at the capabalities pr: https://github.com/apache/iceberg/pull/9940, are we sure we want to add scan-planning as part of the capabilities list in the ConfigResponse? One question i want to raise is if server returns back scan-planning in the capabalities, would this mean that all tables under RestCatalog would support scan planning?

I believe that we need a way tell clients the rest scan planning is supported, but I think this is something that should be done at the table level, in the LoadTableResponse maybe as a new property? Let me know what you all think

rahil-c avatar Apr 02 '24 20:04 rahil-c

@rdblue @danielcweeks @jackye1995 Was wondering if you guys can take a look at this pr when you get a chance?

rahil-c avatar Apr 21 '24 23:04 rahil-c

https://github.com/apache apache deleted a comment from rahil-c (https://github.com/apache/iceberg/pull/9695#event-13139602437) https://github.com/apache deleted a comment from rahil-c (https://github.com/apache/iceberg/pull/9695#event-13139602791)

Saw that apache performed these actions above. Just curious as to which comments were deleted and why? Or if this is some bug from git ui?

rahil-c avatar Jun 13 '24 03:06 rahil-c

https://github.com/apache apache deleted a comment from rahil-c (#9695 (comment)) https://github.com/apache deleted a comment from rahil-c (#9695 (comment))

Saw that apache performed these actions above. Just curious as to which comments were deleted and why? Or if this is some bug from git ui?

@rahil-c, my view shows that it was @jackye1995. I'm not sure why you see just "apache". image

rdblue avatar Jun 18 '24 23:06 rdblue

@rdblue @danielcweeks @amogh-jahagirdar @rahil-c @nastra sorry for the delay, I accidentally deleted the commit locally without a backup, finally digged it out from checking everything in git fsck... Let me know what you think about the updated version!

jackye1995 avatar Jul 09 '24 21:07 jackye1995

let me know what you guys think on the recent changes @rdblue @danielcweeks @amogh-jahagirdar @jackye1995

rahil-c avatar Aug 24 '24 21:08 rahil-c