iceberg icon indicating copy to clipboard operation
iceberg copied to clipboard

Spark: support rewrite on specified target branch

Open zinking opened this issue 2 years ago • 16 comments

why the change

currently, rewrite only happens on main branch. with the branch functionality it is also useful to conduct rewrite related tests on branches

what is changed

added target branch to specify the rewrite target

how is the change tested

added new unit tests to cover the new cases

zinking avatar Oct 11 '23 07:10 zinking

can you also please update the respective docs?

nastra avatar Oct 11 '23 07:10 nastra

can you also please update the respective docs?

do you mean the branch & tagging doc? anywhere else?

zinking avatar Oct 11 '23 08:10 zinking

can you also please update the respective docs?

do you mean the branch & tagging doc? anywhere else?

I mean in the Spark procedures section: https://github.com/apache/iceberg/blob/e5ad5ce4c09d1efcd26e3cf0bd27bcf8c06c2400/docs/spark-procedures.md#rewrite_data_files

nastra avatar Oct 11 '23 09:10 nastra

#8762 associating the original issue here.

zinking avatar Oct 11 '23 10:10 zinking

Just checking on the state of this PR, @zinking is there anything pending to move this forward? @ajantha-bhat @nastra any remaining concerns? With branches and merge-on-read deletes now fixed in branches I think the functionality to rewrite data files is necessary. Thanks everyone!

edgarRd avatar Feb 27 '24 17:02 edgarRd

let me update the PR, and @nastra can have another look.

zinking avatar Feb 28 '24 03:02 zinking

any updates on this ?? is this something thats going to be merged soon

amit-cloudinary avatar May 20 '24 10:05 amit-cloudinary

ping @nastra for another review.

zinking avatar May 21 '24 03:05 zinking

@zinking - if i can assist with this please let me know (would love to contribute if possible)

amit-cloudinary avatar May 27 '24 08:05 amit-cloudinary

@zinking - if i can assist with this please let me know (would love to contribute if possible)

feel free to pick it up here.

zinking avatar May 27 '24 08:05 zinking

@zinking - if i can assist with this please let me know (would love to contribute if possible)

feel free to pick it up here.

Ill give it a try :) ,thanks

amit-cloudinary avatar May 27 '24 08:05 amit-cloudinary