iceberg Build: Apply spotless for scala code

Closes #7695.

Jul 09 '23 08:07 ConeyLiu

@Fokko are we going to force styles on scala as well? not sure why this isn't done when enforcing styles on java.
if the answer is yes, guess we need to do this early instead of late.

Jul 12 '23 01:07 zinking

Hi, @nastra @zinking @Fokko would you mind taking another look at this? Thanks in advance.

Jul 18 '23 02:07 ConeyLiu

Also cc @jackye1995 @amogh-jahagirdar who have disscuessed this at #6736

Jul 18 '23 03:07 ConeyLiu

@ConeyLiu I think this is a great topic to mention on the DEV mailist list & Iceberg Sync, so that people are aware about this effort

Jul 18 '23 06:07 nastra

Thanks @nastra, raised the discussion at the dev mail list.

Jul 18 '23 09:07 ConeyLiu

LGTM now, I'd suggest let's get this style in early.

Jul 19 '23 05:07 zinking

Just linking the conclusion here as I was searching for it. https://lists.apache.org/thread/sv70lr0bwl9jmxtzvho2ml5xcrcpzf3b

Dec 18 '23 10:12 ajantha-bhat

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

Sep 06 '24 00:09 github-actions[bot]

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Sep 19 '24 00:09 github-actions[bot]

@ConeyLiu are you interested in continuing work on this?

May 14 '25 15:05 nastra

Sure, I will rebase it these days.

May 15 '25 03:05 ConeyLiu

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

Jun 15 '25 00:06 github-actions[bot]

@ConeyLiu could you please raise awareness about this on the DEV mailing list so that people have a chance to review this?

Jun 24 '25 07:06 nastra

Also it would be good to update https://github.com/apache/iceberg/blob/8e897f1b68c38c6352f23d636c320e3754d58eef/site/docs/contribute.md#setting-up-ide-and-code-style and mention how to set up IntelliJ with Scalafmt so that formatting inside IntelliJ produces the same formatting results across cmd line (./gradlew spotlessApply) and the IDE

@nastra Does this need a separate commit or rebased into the first commit 'Add scalafmt and config for spotless'

Jun 24 '25 11:06 ConeyLiu

could you please raise awareness about this on the DEV mailing list so that people have a chance to review this?

Done it.

Jun 24 '25 11:06 ConeyLiu

Also it would be good to update https://github.com/apache/iceberg/blob/8e897f1b68c38c6352f23d636c320e3754d58eef/site/docs/contribute.md#setting-up-ide-and-code-style and mention how to set up IntelliJ with Scalafmt so that formatting inside IntelliJ produces the same formatting results across cmd line (./gradlew spotlessApply) and the IDE

@nastra Does this need a separate commit or rebased into the first commit 'Add scalafmt and config for spotless'

I think adding this into the first commit should be fine

Jun 24 '25 13:06 nastra

@singhpk234 Based on the issue and PR in Spotless, the unused imports aren’t handled. We need a separate Scalafix rule to take care of that.

Oct 14 '25 02:10 jackylee-ch

@ConeyLiu where are we with this PR? Could you please rebase it so that we can get it in?

Nov 27 '25 07:11 nastra

I can rebase it today or tomorrow.

Nov 28 '25 01:11 ConeyLiu