iceberg Build: Upgrade netty-buffer to 4.1.89.Final

Mar 02 '23 10:03 XN137

We try to keep Netty in sync with the Spark and Arrow transitive dependencies. What effect does this have on Spark modules?

Mar 03 '23 21:03 rdblue

this is still a draft so not ready for review

that being said, the current version 4.1.68.Final is a version downgrade since the recent arrow upgrade... so i am guessing the current version pin only continues to work because neither spark nor arrow are using APIs that are only available in their newer netty versions.

also not sure why we pin the version ourselves when we want to keep it in sync with one (both?) of the other dependencies, when we could let one of those dependencies pull in "their version"

did we ever hit netty compatibility issues that are not covered by iceberg CI ?

Mar 04 '23 08:03 XN137

Did we ever hit netty compatibility issues that are not covered by iceberg CI?

I think that we have had problems in the past with Netty, but that was a few versions ago for both Arrow and Spark. I think it would be good at this point to just understand what each one is using and what our strategy is. If we can align them, that would be ideal.

Mar 05 '23 23:03 rdblue

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

Aug 28 '24 00:08 github-actions[bot]

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Sep 04 '24 00:09 github-actions[bot]