iceberg icon indicating copy to clipboard operation
iceberg copied to clipboard

Support setting table statistics

Open findepi opened this issue 3 years ago • 2 comments

Implement Transaction.updateStatistics API.

Extracted from https://github.com/apache/iceberg/pull/4741 per https://github.com/apache/iceberg/pull/4741#discussion_r966200811. Probably not testable before that PR is merged.

findepi avatar Sep 19 '22 12:09 findepi

Applied comments, @rdblue please take another look

findepi avatar Sep 20 '22 07:09 findepi

rebased after https://github.com/apache/iceberg/pull/5799 merged, no other changes

@rdblue please take a look

findepi avatar Sep 21 '22 10:09 findepi

Thank you @rdblue for your review!

This looks good other than the separate logic between apply and commit. I think refactoring to use a common internalApply is the only thing blocking this.

done! please take a look

findepi avatar Sep 26 '22 08:09 findepi

I pushed empty commit to diagnose the build failure that occurred in the previous run https://github.com/apache/iceberg/actions/runs/3126381931/jobs/5071814830

The build is green now (https://github.com/apache/iceberg/actions/runs/3127126451/jobs/5073407795)

Empty commits get removed on rebase-and-merge (should someone want to merge this PR), but to avoid confusion I will still remove it from here.

findepi avatar Sep 26 '22 14:09 findepi

Thanks, @findepi!

rdblue avatar Sep 26 '22 16:09 rdblue

Thank you @rdblue for the merge, and all your review comments!

findepi avatar Sep 27 '22 07:09 findepi