API/Core: Remove deprecated methods from Snapshot API

Open nastra opened this issue 3 years ago • 2 comments

This also refactors the Snapshot API to track v1 manifest locations and lazily load them when needed, thus removing the need for FileIO in the different parsers

Sep 09 '22 15:09 nastra

This looks great to me, other than a minor serialization convention (prefer arrays to lists for Kryo) and adding a public API method that I don't think we need. Thanks, @nastra!

Sep 11 '22 21:09 rdblue

@rdblue we discussed removing write.manifest-lists.enabled and relevant code paths, should we go ahead and merge this PR here and tackle the removal around write.manifest-lists.enabled in a separate PR mainly because this PR would get even bigger than it is right now?

Sep 15 '22 21:09 nastra

Thanks, @nastra! Looks great. I merged this and we can follow up on #5773.

Sep 23 '22 21:09 rdblue