iceberg icon indicating copy to clipboard operation
iceberg copied to clipboard

Flink: Use Tag or Branch to scan data.

Open hililiwei opened this issue 2 years ago • 2 comments

This PR is blocked on #4428

What is the purpose of the change

Scan data using a specified tag or branch.

Brief change log

Add the following syntax SQL:

* SELECT * FROM sample /*+ OPTIONS('tag'='t1')*/ ;
* SELECT * FROM sample /*+ OPTIONS('branch'='t1')*/ ;

API:

    public Builder tag(String tag) {
      contextBuilder.useTag(tag);
      return this;
    }

    public Builder branch(String branch) {
      contextBuilder.useBranch(branch);
      return this;
    }
    public Builder startTag(String startTag) {
      contextBuilder.startTag(startTag);
      return this;
    }

    public Builder endTag(String endTag) {
      contextBuilder.endTag(endTag);
      return this;
    }

cc @amogh-jahagirdar

hililiwei avatar Jun 14 '22 06:06 hililiwei

This has a dependency on https://github.com/apache/iceberg/pull/4428/files, I will follow up on that PR.

amogh-jahagirdar avatar Jun 17 '22 03:06 amogh-jahagirdar

As the core is being modified, this PR needs to wait for #5364 and #5475 to complete.

hililiwei avatar Aug 09 '22 01:08 hililiwei

cc @amogh-jahagirdar @stevenzwu

hililiwei avatar Oct 18 '22 12:10 hililiwei

cc @amogh-jahagirdar @stevenzwu @rdblue, could you please take a look when you are available?

hililiwei avatar Nov 07 '22 12:11 hililiwei

@stevenzwu since you are reviewing #6660, could you also take a look at this?

jackye1995 avatar Feb 03 '23 01:02 jackye1995

@stevenzwu addressed the round of comments, PTAL, thx.

hililiwei avatar Feb 13 '23 07:02 hililiwei

Looks like all comments are addressed and we have enough votes, thanks for the work @hililiwei , and thanks for the review @stevenzwu and @amogh-jahagirdar !

jackye1995 avatar Feb 14 '23 15:02 jackye1995

Thanks for the review @jackye1995 @stevenzwu @amogh-jahagirdar

hililiwei avatar Feb 15 '23 06:02 hililiwei