iceberg icon indicating copy to clipboard operation
iceberg copied to clipboard

Expose table statistics in Table API

Open findepi opened this issue 3 years ago • 12 comments

Follows https://github.com/apache/iceberg/pull/4945 and https://github.com/apache/iceberg/pull/5021

findepi avatar May 10 '22 12:05 findepi

@findepi, I think this is too big to go in on its own. Can you split it into separate PRs for different parts?

rdblue avatar May 10 '22 15:05 rdblue

@rdblue i have this split. https://github.com/apache/iceberg/pull/4537 has already been reviewed.

findepi avatar May 10 '22 20:05 findepi

We need to remember to keep remove_orphan_files from deleting Statistics files

alexjo2144 avatar May 18 '22 19:05 alexjo2144

We need to remember to keep remove_orphan_files from deleting Statistics files

Thanks for reminding about this here. It's on my todo list, see eg https://github.com/trinodb/trino/pull/12317#discussion_r876044928

findepi avatar May 19 '22 07:05 findepi

We need to remember to keep remove_orphan_files from deleting Statistics files

Fixed & test added.

findepi avatar May 20 '22 09:05 findepi

Conflicting files .palantir/revapi.yml core/src/main/java/org/apache/iceberg/BaseSnapshot.java

ops.

findepi avatar Jun 02 '22 12:06 findepi

Updated to the current state of https://github.com/apache/iceberg/pull/5021

findepi avatar Aug 29 '22 15:08 findepi

Rebased after #5021 has been merged to make Conflicts disappear.

findepi avatar Aug 30 '22 17:08 findepi

@rdblue please let me know if you have any comments.

findepi avatar Sep 06 '22 13:09 findepi

Per https://github.com/apache/iceberg/pull/4741#discussion_r966200811, I've shrunk the scope of this PR and extracted https://github.com/apache/iceberg/pull/5794 and also https://github.com/apache/iceberg/pull/5795 .

findepi avatar Sep 19 '22 12:09 findepi

Thanks, @findepi! I'll give this another look.

rdblue avatar Sep 19 '22 18:09 rdblue

Thanks @rdblue . https://github.com/apache/iceberg/pull/5799 might be the easiest to start from.

findepi avatar Sep 19 '22 18:09 findepi

@rdblue this is ready to review.

findepi avatar Sep 27 '22 11:09 findepi

Thanks, @findepi!

rdblue avatar Sep 29 '22 21:09 rdblue

Thank you for the merge!

findepi avatar Sep 30 '22 09:09 findepi