iceberg icon indicating copy to clipboard operation
iceberg copied to clipboard

Make retry number and backoff policy configurable

Open timothy-khom opened this issue 3 years ago • 4 comments

Hi colleagues, Could the hard-coded value of numRetries at https://github.com/apache/iceberg/blob/0.12.x/core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java#L160 and backoff policy at https://github.com/apache/iceberg/blob/0.12.x/core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java#L175 be specified via configuration somehow? When there is an intermittent network issue or so it is usually enough to retry less times. Otherwise, for instance if there is a stale information in metadata for some reason and the underlying files do not exist this retry mechanism causes overall process to “stuck” for 10 mins unnecessarily retrying the read operation.

timothy-khom avatar Jan 14 '22 09:01 timothy-khom

Hi,I think this is solved by https://github.com/apache/iceberg/pull/3099, (you can pass the relevant configs now supported by RetryingHiveMetaStoreClient) can you check?

szehon-ho avatar Jan 14 '22 18:01 szehon-ho

Hi @szehon-ho, Thank you for suggestion. However it seems it will be available in 0.13.x won't it ?

timothy-khom avatar Jan 18 '22 06:01 timothy-khom

Yea i think in current versions there is no good way I could find, unfortunately.

szehon-ho avatar Jan 19 '22 17:01 szehon-ho

This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.

github-actions[bot] avatar Aug 06 '22 00:08 github-actions[bot]

This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'

github-actions[bot] avatar Aug 21 '22 00:08 github-actions[bot]