iceberg icon indicating copy to clipboard operation
iceberg copied to clipboard

Consider adding extra validation for metrics config when creating a table

Open aokolnychyi opened this issue 4 years ago • 5 comments

What I see frequently is that people clone some examples but miss to update the metrics config. As a result, it points to fields that don't exist. I think we should consider doing some checks while creating a table to ensure metrics config references columns in our schema. It is important to get the metrics config right while creating a table.

aokolnychyi avatar Oct 02 '20 21:10 aokolnychyi

@holdenk, would you have time to look into this? Not urgent.

aokolnychyi avatar Oct 13 '20 18:10 aokolnychyi

@aokolnychyi IMO, MetricsConfig could add validateProperties method to check metrics config references columns in schema, and the method should be called in createTable(). Is this similar with your point?

SteNicholas avatar Oct 15 '20 06:10 SteNicholas

@SteNicholas, yeah, that's something I had in mind.

aokolnychyi avatar Oct 28 '20 17:10 aokolnychyi

Rocking, I've finally got a bit of time for next week, I'll pick this up :)

holdenk avatar Dec 16 '20 17:12 holdenk

This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.

github-actions[bot] avatar Feb 27 '24 00:02 github-actions[bot]

This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'

github-actions[bot] avatar Mar 13 '24 00:03 github-actions[bot]