Kafka Connect: Add option to fail connector task after max retries
Hi team,
I add a few more configs:
private static final String COMMIT_MAX_RETRIES_PROP = "iceberg.control.commit.max-retries";
private static final int COMMIT_MAX_RETRIES_DEFAULT = 3;
private static final String COMMIT_MIN_RETRY_WAIT_MS_PROP = "iceberg.control.commit.min-retry-wait-ms";
private static final int COMMIT_MIN_RETRY_WAIT_MS_DEFAULT = 100;
private static final String COMMIT_MAX_RETRY_WAIT_MS_PROP = "iceberg.control.commit.max-retry-wait-ms";
private static final int COMMIT_MAX_RETRY_WAIT_MS_DEFAULT = 60_000;
private static final String COMMIT_TOTAL_RETRY_TIME_MS_PROP = "iceberg.control.commit.total-retry-time-ms";
private static final int COMMIT_TOTAL_RETRY_TIME_MS_DEFAULT = 300_000; // 5 minutes
public static final String FAIL_ON_MAX_COMMIT_RETRIES = "fail.on.max.commit.retries";
public static final boolean FAIL_ON_MAX_COMMIT_RETRIES_DEFAULT = false;
if we set fail.on.max.commit.retries=true, the connector task will fails after some retries. The default value of fail.on.max.commit.retries is false to maintain backward compatibility
Fixes https://github.com/apache/iceberg/issues/13117
Can you also please update the documentation for these? https://github.com/apache/iceberg/blob/main/docs/docs/kafka-connect.md
@liko9 Thank you for the feedback, I have added my changes to the Kafka Connect documentation!
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
Hi @kevinjqliu Could you help to take a look at this PR as well ? :pray:
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
@kevinjqliu could you help taking at this again pls :bow: ?
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.