iceberg icon indicating copy to clipboard operation
iceberg copied to clipboard
verified publisher icon apache

Build: Fix errorprone warnings

Open CuteChuanChuan opened this issue 6 months ago • 2 comments

Summary:

  • Solve https://github.com/apache/iceberg/issues/13178

Details:

  • UnnecessaryParentheses at ADLSFileIO#136: remove unnecessary parentheses
  • ObjectsHashCodePrimitive at DynamicRecordInternalSerializer#234: use Boolean.hashCode instead of Objects.hashCode
  • MixedMutabilityReturnType at DynamicWriter#202: use ImmutableList for consistent immutable collection returns
  • ImmutableEnumChecker at Timestamps#47: replace SerializableFunction with @Immutable Apply class for enum immutability
  • DangerousParallelStreamUsage at BigQueryMetastoreClientImpl#491: replace parallel stream with Tasks.foreach() for consistent project pattern

Verification:

  1. Run ./gradlew clean build -x test -x integrationTest --no-build-cache to ensure no ErrorProne warnings
  2. Run ./gradlew :iceberg-bigquery:test to verify BigQueryMetastoreClientImpl modifications pass tests
  3. Run ./gradlew :iceberg-api:test to verify Timestamps modifications don't break existing functionality

CuteChuanChuan avatar Jun 02 '25 13:06 CuteChuanChuan

Hi @ajantha-bhat, I've resolved the conflicts and rebased against the latest upstream-main. There is no error prone warning in build. PTAL when you have a chance. Thanks!

CuteChuanChuan avatar Jun 15 '25 07:06 CuteChuanChuan

Hi @ajantha-bhat , thanks for the heads-up. The nit is solved. Thanks!

CuteChuanChuan avatar Jun 16 '25 13:06 CuteChuanChuan

@nastra, @pvary: anymore comments for this? +1 from my side.

ajantha-bhat avatar Jun 25 '25 07:06 ajantha-bhat

Hi @nastra,

Thanks for the feedback. PTAL when you have a chance.

CuteChuanChuan avatar Jun 25 '25 14:06 CuteChuanChuan

Closes https://github.com/apache/iceberg/issues/13178

CuteChuanChuan avatar Jun 30 '25 10:06 CuteChuanChuan