iceberg Drop support for Java 8

Relates to: https://github.com/apache/iceberg/pull/10474

Jun 17 '24 14:06 findepi

just FYI that you'd also need to update https://github.com/apache/iceberg/blob/2519ab43d654927802cc02e19c917ce90e8e0265/deploy.gradle#L21

https://github.com/apache/iceberg/blob/715140113a1d30dc213e677a7d65a5dbe51dde90/site/docs/contribute.md#L87

https://github.com/apache/iceberg/blob/b7a0bea6e5cd31b871bd6e038ff78588d80a6655/README.md#L54

Jun 20 '24 13:06 nastra

just FYI that you'd also need to update

good point, updated. also found couple different places where we inspect JavaVersion.current()

Jun 20 '24 14:06 findepi

This PR can also help in unblocking parquet version bump: https://github.com/apache/iceberg/pull/10209#issuecomment-2230123181

@findepi: Are you still working on this? I think this one is more important than JDK 21 support.

Jul 16 '24 06:07 ajantha-bhat

@snazy, @jbonofre: Can you please also review this?

Jul 16 '24 06:07 ajantha-bhat

This PR can also help in unblocking parquet version bump: #10209 (comment)

Thanks @ajantha-bhat for linking the two!

@findepi: Are you still working on this? I think this one is more important than JDK 21 support.

Technically this PR is ready to go (i.e. please review!). However, there is no agreement yet as to when this should be merged, see the thread on the mailing list.

Jul 16 '24 06:07 findepi

However, there is no agreement yet as to when this should be merged, see the thread on the mailing list.

Please have a separate discussion for dropping JDK 8 support. Mixing things can slowdown the decision making usually. Also mention that it is needed to unblock the parquet bump.

Jul 16 '24 06:07 ajantha-bhat

@ajantha-bhat it's not really mixed. I intended the thread to focus on adding 21, but folks decided to focus on dropping 8, as this clearly is more important, so this is all the thread is about. I wish we could just change it's title...

Jul 16 '24 08:07 findepi

making java11 your base version is great -but you'll need a followup of 'cut hadoop-2' profile. this is a good thing
java 22 is going to break a lost as they will cut Subject.doAs(), which used throughout multi-user services. just be aware that it'll be traumatic.

Jul 21 '24 13:07 steveloughran

( rebased to resolve conflicts with now-merged https://github.com/apache/iceberg/pull/10474, no other changes )

Jul 25 '24 21:07 findepi

Rebased to update formatting in flink/v1.19 classes. I will move the baseline update commit to separate PR though.

Jul 26 '24 11:07 findepi

Moved to 1.7.0 milestone per [VOTE] Drop Java 8 support in Iceberg 1.7.0 mail list thread. Will merge tomorrow.

Aug 01 '24 21:08 findepi

Thanks for getting this through, @findepi!

Aug 02 '24 15:08 rdblue

nice. now, who is going to do the "drop hadoop2 profile", so letting iceberg move to filesystem APIs written since 2016?

Aug 13 '24 09:08 steveloughran

@steveloughran do you want to do the honors @steveloughran?

Aug 13 '24 10:08 Fokko

can give it a go, its time I learned gradle properly. but busy with helping getting 3.4.1 out the door, including those final changes

Aug 13 '24 10:08 steveloughran

@Fokko started that PR. #10932 ...looks like hive2 is dead too. This good in that it will significantly reduce test profiles -but it is going to make the PR at lot more complex. I think I may be getting out of my depth build-wise before very long

Aug 13 '24 18:08 steveloughran