iceberg-rust icon indicating copy to clipboard operation
iceberg-rust copied to clipboard

feat: SQL Catalog - Tables

Open callum-ryan opened this issue 1 year ago • 1 comments

this is a WIP. Pulling tests in from @fqaiser94's original recommended test set as I go.

callum-ryan avatar Sep 07 '24 13:09 callum-ryan

Thanks @callum-ryan for this great pr! Generally LGTM, I've left some minor points to fix, others are great! One thing I want to ask is that do we have plan for tests against other databases such as postgres, mysql?

Thanks @liurenjie1024, I have fixed the points raised. I'm happy to take a look at integration tests for PostgreSQL and MySQL, it will take me some extra time as I am unfamiliar with the way these tests run for the repo. The REST catalog tests seem to be doing what I'd need to spin up some containers with the appropriate backends.

callum-ryan avatar Sep 30 '24 18:09 callum-ryan