iceberg-rust icon indicating copy to clipboard operation
iceberg-rust copied to clipboard

`typed-builder` and `derive_builder` are both used

Open Xuanwo opened this issue 1 year ago • 5 comments

Should we stick to one builder crate instead?

Xuanwo avatar Aug 14 '24 13:08 Xuanwo

I'm in favor of using typed-builder only, but the problem is that its type is not clear, which maybe a problem when you want to save a builder in your struct.

liurenjie1024 avatar Aug 14 '24 14:08 liurenjie1024

cc @liurenjie1024, is this issue still valid? I can help address this.

Xuanwo avatar Sep 15 '25 09:09 Xuanwo

Seems it still exists.

liurenjie1024 avatar Sep 15 '25 09:09 liurenjie1024

Do we really want users to store builder in struct?

Xuanwo avatar Sep 15 '25 09:09 Xuanwo

Do we really want users to store builder in struct?

Good question, I think we should have some abstractions like Factory to do that if necessary. But I'm not sure about all details.

liurenjie1024 avatar Sep 15 '25 10:09 liurenjie1024