feat: SQL Catalog - namespaces

Open callum-ryan opened this issue 1 year ago • 2 comments

Carrying on from PR #524 , this is the implementation of the namespace functionality

Aug 09 '24 19:08 callum-ryan

Hi, I need more time to review the SQL individually. Here are some additional comments that I believe should take priority.

By the way, have you considered using diesel instead? I find it easier to maintain compared to raw SQL.

Personal preference but I tend to avoid ORMs - I can see that Java has gone the raw SQL way, and Python uses sqlalchemy's ORM. Happy to put this up for discussion.

Aug 12 '24 17:08 callum-ryan

I'm also ok with this being SQL rather than Diesel. Diesel feels like a large dependency to bring in for a small number of quite straightforward queries.

Aug 12 '24 19:08 sdd

I wonder if its possible to expose this as Python API and also test against the python unit tests

Hi, @kevinjqliu I'm fine with adding it in pyiceberg_core module. But instead of adding sql catalog only, I think it's better to add a wrapper around Catalog trait? What do you think?

Sep 05 '24 02:09 liurenjie1024