Add `miri` to detect undefined behavior.
miri is a tool to help to discover undefined behavior in rust programs. We should add this in ci to ensure no vilation of rust spec.
For a high-level project like iceberg, perhaps we could avoid using unsafe?
For a high-level project like
iceberg, perhaps we could avoid usingunsafe?
I agree that we should avoid using unsafe as much as possible, but it's possible that our dependency may use unsafe?
Hello, I'm new and would like to contribute to this project. If this task is still available, I'd be interested in working on it as it would help me familiarize myself with the codebase. Please let me know if I can take this on.
Hello, I'm new and would like to contribute to this project. If this task is still available, I'd be interested in working on it as it would help me familiarize myself with the codebase. Please let me know if I can take this on.
Hi, @GeetKrishna Welcome to contribute! Yeah this has not started yet, feel free to work on it.
I have picked this up and I'm implementing in #1611 . Some tests have to be explicitly skipped due to lack of miri support but I think there's good progress on this.
One thing to note is the speed -- it can take around 30 minutes to complete.
I agree that we should avoid using
unsafeas much as possible, but it's possible that our dependency may useunsafe?
I think think it's not part of our job 😆