iceberg-rust icon indicating copy to clipboard operation
iceberg-rust copied to clipboard

Add `miri` to detect undefined behavior.

Open liurenjie1024 opened this issue 1 year ago • 6 comments

miri is a tool to help to discover undefined behavior in rust programs. We should add this in ci to ensure no vilation of rust spec.

liurenjie1024 avatar Jul 06 '24 10:07 liurenjie1024

For a high-level project like iceberg, perhaps we could avoid using unsafe?

Xuanwo avatar Jul 06 '24 10:07 Xuanwo

For a high-level project like iceberg, perhaps we could avoid using unsafe?

I agree that we should avoid using unsafe as much as possible, but it's possible that our dependency may use unsafe?

liurenjie1024 avatar Jul 06 '24 10:07 liurenjie1024

Hello, I'm new and would like to contribute to this project. If this task is still available, I'd be interested in working on it as it would help me familiarize myself with the codebase. Please let me know if I can take this on.

gkpanda4 avatar Jun 16 '25 21:06 gkpanda4

Hello, I'm new and would like to contribute to this project. If this task is still available, I'd be interested in working on it as it would help me familiarize myself with the codebase. Please let me know if I can take this on.

Hi, @GeetKrishna Welcome to contribute! Yeah this has not started yet, feel free to work on it.

liurenjie1024 avatar Jun 18 '25 01:06 liurenjie1024

I have picked this up and I'm implementing in #1611 . Some tests have to be explicitly skipped due to lack of miri support but I think there's good progress on this.

One thing to note is the speed -- it can take around 30 minutes to complete.

atcol avatar Aug 18 '25 12:08 atcol

I agree that we should avoid using unsafe as much as possible, but it's possible that our dependency may use unsafe?

I think think it's not part of our job 😆

Xuanwo avatar Oct 28 '25 17:10 Xuanwo