iceberg-rust icon indicating copy to clipboard operation
iceberg-rust copied to clipboard

Sql catalog

Open JanKaul opened this issue 1 year ago • 6 comments

This PR implements the basic operations for a Sql catalog. The implementation uses the sqlx crate which enables Postgres, MySQL and Sqlite.

The update_table method is to be implemented later.

JanKaul avatar Mar 04 '24 15:03 JanKaul

PTAL @liurenjie1024 @Xuanwo @ZENOTME @Fokko

JanKaul avatar Mar 04 '24 16:03 JanKaul

cc @JanKaul Is this pr ready for review or you need to do more updates?

liurenjie1024 avatar Apr 16 '24 14:04 liurenjie1024

I have to add a couple of more changes. I'll notify you when I'm finished.

JanKaul avatar Apr 17 '24 05:04 JanKaul

@JanKaul WDYT? I think this PR is ready for review, I can add the update and delete in a separate PR.

himadripal avatar Apr 18 '24 04:04 himadripal

@JanKaul WDYT? I think this PR is ready for review, I can add the update and delete in a separate PR.

Cool, I'll take a look first.

liurenjie1024 avatar Apr 25 '24 03:04 liurenjie1024

Thank you all for your helpful comments. I think the PR is ready for review again.

@liurenjie1024 @sdd @odysa @ZENOTME @martin-g

JanKaul avatar Apr 25 '24 08:04 JanKaul

the bind placeholder ? will not work with pg databases, which use $1..$N format unfortunately. sqlx docs

callum-ryan avatar Jun 21 '24 20:06 callum-ryan

Thanks for bringing this up, I haven't thought about it. It's weird though, the test is using sqlite which it's supposed to not work with ? according to the docs.

JanKaul avatar Jun 22 '24 06:06 JanKaul