iceberg-rust icon indicating copy to clipboard operation
iceberg-rust copied to clipboard

feat: Add optional prefetch hint for parsing Puffin Footer

Open jonathanc-n opened this issue 8 months ago • 5 comments

Which issue does this PR close?

  • Closes #1198.

What changes are included in this PR?

Add prefetch hint for parsing puffin footer + change some docs

Are these changes tested?

Yes, unit tested

jonathanc-n avatar Apr 14 '25 00:04 jonathanc-n

cc @Xuanwo @fqaiser94

jonathanc-n avatar Apr 14 '25 01:04 jonathanc-n

Hi, I believe this hint should be optional and we shouldn't require all users to provide it.

Xuanwo avatar Apr 17 '25 03:04 Xuanwo

@Xuanwo It is optional, let me change the title. Or do you mean that i should add a function like with_prefetch_hint and have the hint be in the struct?

jonathanc-n avatar Apr 17 '25 03:04 jonathanc-n

Or do you mean that i should add a function like with_prefetch_hint and have the hint be in the struct?

Yep. I believe we should not change the read API.

Xuanwo avatar Apr 17 '25 03:04 Xuanwo

@Xuanwo Thanks for the review, it is fixed!

jonathanc-n avatar Apr 22 '25 21:04 jonathanc-n