iceberg-python icon indicating copy to clipboard operation
iceberg-python copied to clipboard

Build: Bump pytest from 7.4.4 to 8.0.0

Open hussein-awala opened this issue 1 year ago • 3 comments

Alternative for #319

pytest-lazy-fixture is not compatible with pytest v8, and it looks like it will be never compatible as the project is not active anymore, there is a discussion to move/add lazy_fixture to pytest, but we don't know yet if this will happen or not.

This PR removes the package pytest-lazy-fixture and the usage of lazy_fixture, then uses the fixture request to load the fixture by its name.

hussein-awala avatar Feb 07 '24 21:02 hussein-awala

CI is green 🎉

Please check https://github.com/TvoroG/pytest-lazy-fixture/issues/65 for the issue

cc: @Fokko

hussein-awala avatar Feb 07 '24 21:02 hussein-awala

Circling back to this now the release is out. I do like the lazy-fixture, and it solved some real problems. Also, the request seems to fix the problem, but erases all typing and is more verbose. There seems to be quite a bit of activity on the thread, maybe we should give it a bit more time?

Fokko avatar Feb 20 '24 21:02 Fokko

Yes, we can wait two weeks, and if there is no solution to this issue, we can discuss merging this PR or adopting a different solution.

hussein-awala avatar Feb 20 '24 22:02 hussein-awala

@hussein-awala It looks like there is a fork that's compatible with pytest>=7.0.0: https://github.com/dev-petrov/pytest-lazy-fixtures

celebration-happy

Fokko avatar Oct 30 '24 19:10 Fokko