iceberg-python icon indicating copy to clipboard operation
iceberg-python copied to clipboard
verified publisher icon apache

check-md-link has been failing

Open kevinjqliu opened this issue 2 months ago • 2 comments

Apache Iceberg version

None

Please describe the bug 🐞

https://github.com/apache/iceberg-python/blob/main/.github/workflows/check-md-link.yml

The action tcort/github-action-markdown-link-check@v1 is not allowed in apache/iceberg-python because all actions must be from a repository owned by your enterprise, created by GitHub, verified in the GitHub Marketplace, or match one of the patterns: 1Password/load-secrets-action@13f58eec611f8e5db52ec16247f58c508398f3e6, AdoptOpenJDK/install-jdk@, BobAnkh/auto-generate-changelog@, DavidAnson/markdownlint-cli2-action@992badcdf24e3b8eb7e87ff9287fe931bcb00c6e, EnricoMi/publish-unit-test-result-action@, JamesIves/github-pages-deploy-action@6c2d9db40f9296374acc17b90404b6e8864128c8, JustinBeckwith/linkinator-action@3d5ba091319fa7b0ac14703761eebb7d100e6f6d, Kesin11/actions-timeline@54d513e0b5ff1158f1cf8321108d666a5a6c1fca, Kesin11/actions-timeline@a7eaabf426cdae26c3582c3fa674b897170dec8f, PyO3/maturin-action@, TobKed/label-when-approved-action@*, VirtusLab/scala-cli-setup@54cd42adb92642fffd3b04cf9705d2806a3b8a92, VirtusLab/scala-cli-setup@77834b5926f3eb70869d8009530c65585f7a039b, Virtu...

Example recent run: https://github.com/apache/iceberg-python/actions/runs/19179850959

Got alerted to github run failure via email

Willingness to contribute

  • [ ] I can contribute a fix for this bug independently
  • [ ] I would be willing to contribute a fix for this bug with guidance from the Iceberg community
  • [ ] I cannot contribute a fix for this bug at this time

kevinjqliu avatar Nov 07 '25 20:11 kevinjqliu

changed in https://github.com/apache/iceberg-python/commit/423487900d7b79aaf35ea1feb1930405511dc410

but looks like tcort/github-action-markdown-link-check is not on the apache infra approved list

https://github.com/apache/infrastructure-actions/blame/40a10f0f472a72d0be8c99671fdfce6775217166/approved_patterns.yml#L91

kevinjqliu avatar Nov 07 '25 20:11 kevinjqliu

https://issues.apache.org/jira/browse/INFRA-27388

filed an infra ticket

kevinjqliu avatar Nov 07 '25 20:11 kevinjqliu

tcort/github-action-markdown-link-check is added to apache infra allowlist https://github.com/apache/infrastructure-actions/pull/368#event-20985422181

kevinjqliu avatar Nov 17 '25 16:11 kevinjqliu

Need to pin to specific hash (see #2765) and the workflow ran successfully! https://github.com/apache/iceberg-python/actions/runs/19449202460

kevinjqliu avatar Nov 18 '25 00:11 kevinjqliu