iceberg-python icon indicating copy to clipboard operation
iceberg-python copied to clipboard

Published 20 hours ago • verified publisher icon apache

support python 3.12

Open MehulBatra opened this issue 1 year ago • 12 comments

  1. ray seems to be a blocker as they do not support python3.12 as of now
image

[Open Ticket for Ray 3.12 Support] (https://github.com/ray-project/ray/issues/40211)

  1. duckdb doesn't support 3.12 and still has a build mechanism via distutils
  • Tentative release for Duckdb supporting 3.12 is 29Jan, Version 0.10
image

  1. Dual version dependency for numpy to support 3.12,

  2. Upgraded greenlet to 3.0.3 to support Python 3.12, with dual dependency

  3. python 3.12 no longer supports distutils PEP632, we need to upgrade packages that get installed with support of PEP517 builds

MehulBatra avatar Jan 07 '24 20:01 MehulBatra

Similar to

  • #35

@Fokko Can you please approve the workflow run so we can see the results of the tests?

cclauss avatar Jan 13 '24 08:01 cclauss

@MehulBatra can you rebase?

Fokko avatar Mar 13 '24 07:03 Fokko

@MehulBatra can you rebase?

rebased it but It will still fail for 3.12 due to ray support, I am keeping a close eye on it.

MehulBatra avatar May 18 '24 15:05 MehulBatra

Tentative ray support for 3.12 -> https://github.com/ray-project/ray/issues/40211#issuecomment-2102962786

MehulBatra avatar May 18 '24 17:05 MehulBatra

PR being worked on for Ray 3.12: https://github.com/ray-project/ray/issues/45477

MehulBatra avatar May 22 '24 10:05 MehulBatra

FYI: Ray issue 45477 was recently completed.

pdpark avatar Jun 04 '24 22:06 pdpark

FYI: Ray issue 45477 was recently completed.

Thank you so much for the update! @pdpark Soon there will be a release too I believe (will keep an eye on the same), and then we can hit the road!

MehulBatra avatar Jun 05 '24 07:06 MehulBatra

@Fokko could you please run the CI/CD

MehulBatra avatar Jul 01 '24 12:07 MehulBatra

@MehulBatra Certainly! How do you feel like splitting the strtobool into a separate PR? I think it would be good to already have that in to enable Python 3.12 support with engines other than Ray.

Fokko avatar Jul 01 '24 13:07 Fokko

@MehulBatra Certainly! How do you feel like splitting the strtobool into a separate PR? I think it would be good to already have that in to enable Python 3.12 support with engines other than Ray.

That makes sense, I will raise separate PR for the same.

MehulBatra avatar Jul 01 '24 14:07 MehulBatra

@Fokko I have separated the strtobool in a separate PR, please have a look https://github.com/apache/iceberg-python/pull/880

MehulBatra avatar Jul 01 '24 15:07 MehulBatra

pytest is kicking out a bunch of warnings that someone should be investigating.

Python 3.13 is in beta 3 so should testing be started on it as well? https://www.python.org/download/pre-releases

cclauss avatar Jul 02 '24 05:07 cclauss

looks like the next release of ray should hopefully have 3.12 support

Jiafi avatar Aug 29 '24 20:08 Jiafi

Cool! Python 3.13 is scheduled to be released on October 1st.

cclauss avatar Aug 29 '24 21:08 cclauss

hey @MehulBatra, can i close this in favor of #1068?

kevinjqliu avatar Sep 09 '24 18:09 kevinjqliu

hey @MehulBatra, can i close this in favor of #1068?

yes please go ahead @kevinjqliu

MehulBatra avatar Sep 12 '24 12:09 MehulBatra