iceberg-python icon indicating copy to clipboard operation
iceberg-python copied to clipboard
verified publisher icon apache

Make X-Client-Version header more similar to Iceberg Java

Open creechy opened this issue 4 months ago • 5 comments

Feature Request / Improvement

It appears that PyIceberg sends an X-Client-Version header with simply the semantic version (like 0.9.1) while the Iceberg Java version includes more information, (like Apache Iceberg 1.9.2 (commit 071d5606bc6199a0be9b3f274ec7fbf111d88821)). It would be great if PyIceberg sent something similar. Minimally, include that its "PyIceberg" in the version - Apache PyIceberg 0.9.1.

creechy avatar Aug 22 '25 15:08 creechy

great idea, the header is set here

looks like the java iceberg client sends the client version and git commit https://github.com/apache/iceberg/blob/b82dac4858fb2d15929a797660252c50f8e00ed8/core/src/main/java/org/apache/iceberg/rest/HTTPClient.java#L533-L534

@creechy Would you like to contribute this change?

kevinjqliu avatar Aug 22 '25 20:08 kevinjqliu

Ok so I got that slightly wrong, I was seeing a 0.14.1, assumed it was PyIceberg but its actually pre-1.0 Java implementation. Ha. Anyways, I'll put it on my backlog to take a look at it myself.

creechy avatar Aug 22 '25 23:08 creechy

Hi @kevinjqliu , if it's okay with you, I'd love to take this.

rahulmansharamani14 avatar Aug 28 '25 01:08 rahulmansharamani14

@rahulmansharamani14 @kevinjqliu if it's okay with you, i'd love to work on this!

axwell0 avatar Sep 27 '25 17:09 axwell0

hey @rahulmansharamani14 and @axwell0, i just saw the comments. Feel free to work on any issues that hasn't been worked on already. Looks like #2652 is already in progress for this issue

kevinjqliu avatar Oct 26 '25 20:10 kevinjqliu