iceberg-python icon indicating copy to clipboard operation
iceberg-python copied to clipboard

#1820 Add Geography/Geometry type

Open Gawaboumga opened this issue 5 months ago • 6 comments

Rationale for this change

Iceberg V3 supports both Geography & Geometry types.

Are these changes tested?

Not enough

Gawaboumga avatar Jul 20 '25 18:07 Gawaboumga

@Gawaboumga were you still planning to work on this? If not, I'd be happy to take it over to get this over the finish line sooner. I've worked a lot with geospatial data, so I'm fairly familiar already.

petern48 avatar Sep 09 '25 19:09 petern48

Do you know what's currently missing in this implementation ? I also wanted to use geospatial data but as this project is not mature, I had to find an alternative ...

Gawaboumga avatar Sep 10 '25 06:09 Gawaboumga

I honestly haven't dug deep into this myself yet, so I'm not sure what else or how much is left for this implementation. But getting the tests to pass would be a good next step. From there, we should ensure that reading and writing geo data works properly when using the public api.

petern48 avatar Sep 12 '25 05:09 petern48

@Gawaboumga, It looks like workflows won't run automatically since it's your first PR in this repo, so it would probably be easiest for you to run CI in your own fork to debug (otherwise, a maintainer would need to manually approve CI to run after each commit).

Were you planning to continue this soon? If not, may I take over? I'm not yet familiar enough with this repo to know what's missing, but I think I can figure it all out if I start from scratch and build out this feature myself. I've got a bit of extra time on my hands nowadays, so now would be a good time.

petern48 avatar Sep 27 '25 17:09 petern48

Note that this PR should be aware of this PR: https://github.com/apache/iceberg/pull/12667

The Iceberg Geo implementation is somehow blocked by if we want to drop the longitude wraparound of geometries.

jiayuasu avatar Sep 29 '25 18:09 jiayuasu

I recreated the branch to make it cleaner. apache/iceberg#12667 would make more sense to be implemented in its own PR.

Gawaboumga avatar Oct 05 '25 14:10 Gawaboumga