iceberg-python icon indicating copy to clipboard operation
iceberg-python copied to clipboard

feat: `validation_history` and `ancestors_between`

Open jayceslesar opened this issue 8 months ago • 1 comments

Rationale for this change

Adds validation_history that will be used in support of https://github.com/apache/iceberg-python/issues/819

Also adds ancestors_between.

Based off of the java implementation but we will likely want changes that feel more like python :). Already took a few liberties there

Are these changes tested?

Added tests

References:

java implementation of validation_history: https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java#L859

java implementation of ancestors_between: https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java#L213

jayceslesar avatar Apr 18 '25 20:04 jayceslesar

Hi @jayceslesar ! Thank you for pressing on with this PR! This looks almost good to merge. I share the same concerns with @Fokko regarding the validation check - I fear that it's currently not checking the right condition. Let's get that fix in, and merge this PR in soon! 🥳

sungwy avatar Apr 27 '25 01:04 sungwy