Documented `row_filter` expressions

Open norton120 opened this issue 9 months ago • 3 comments

Rationale for this change

scan's row_filter param is not super intuitive. I got tired of reading over the expression and parser code as I'm trying to build out statements, so I had some docs made up.

Are these changes tested?

They are docs only, so not really?

Are there any user-facing changes?

Yes there are docs for the expression and string syntaxes of row_filter now.

Mar 31 '25 14:03 norton120

bah 🤦🏻 I clobbered the in-GH changes while rebasing main. grr. I'll have to pick them back first and then can fix per the last open comments

Apr 15 '25 14:04 norton120

Sorry these last fixes took so long I missed the notifications. Updated!

Apr 15 '25 15:04 norton120

@norton120 no worries, thanks for following up! 🙌

Apr 15 '25 18:04 Fokko

I think this is very valuable, and let's merge this and follow up with a PR to clean up the two nits

Jul 03 '25 20:07 Fokko

Thanks @norton120 I think this is a great addition to the docs 🙌 I left some small suggestions, let me know what you think of it 👍

@Fokko sorry, somehow this slipped though my notifications! Thank you for merging, I'm happy to follow up with a cleanup PR re the nits

Jul 03 '25 21:07 norton120