apache
Rewrite manifests
This is an initial implementation of rewrite manifests, aiming to mimic the Java implementation as closely as possible. I’ve tried to follow the same structure and logic, but there are still some areas that might need refinement.
I’m looking for feedback and suggestions on: • Whether the approach aligns well with the existing design. • Any gaps or optimizations that could improve performance. • How best to proceed with completing this feature.
Would love any insights or guidance on the next steps! Thanks in advance for the review! 🙌
Hey @Fokko , yes i am very interested in finishing this, must of missed this (sorry) , will look at this later today :)
Looks like the CI is sad 😞
tests/integration/test_writes/test_rewrite_manifests.py:154: error: "rewrite_manifests" of "Table" does not return a value (it only ever returns None) [func-returns-value]
tests/integration/test_writes/test_rewrite_manifests.py:227: error: "rewrite_manifests" of "Table" does not return a value (it only ever returns None) [func-returns-value]
Hey @Fokko - just wanted to say thanks for reviewing (really appreciate it) . I fixed all your comments and added a test to test v1 -> v2 , hope all pass now. let me know if i have more work todo :)
Hi @amitgilad3 - sorry for the delayed turn around. There's a question in slack regarding this PR, and I wanted to take a stab at helping merging this in, in Fokko's absence.
Are you still interested in working on this PR? Would you be available to resolve the conflicts?
Wondering what the status of this PR is, happy to re-create if you're no longer able to work on it @amitgilad3
Hey @sungwy , @Anton-Tarazi i missed the messages , will fix this week all issues
