iceberg-python icon indicating copy to clipboard operation
iceberg-python copied to clipboard

Support reading initial-defaults

Open Fokko opened this issue 10 months ago • 5 comments

Fokko avatar Feb 11 '25 13:02 Fokko

Since initial-default projection happens after filtering in _task_to_record_batches Im wondering if this will yield the correct results given a pyarrow_filter for this field.

gabeiglio avatar Feb 12 '25 21:02 gabeiglio

Since initial-default projection happens after filtering in _task_to_record_batches Im wondering if this will yield the correct results given a pyarrow_filter for this field.

Thanks for pointing this out, and it doesn't handle the filtering correctly. Let me work on a fix. Thanks!

Fokko avatar Feb 14 '25 19:02 Fokko

No problem! I was trying to get a test case for this by evolving the schema of a table and adding a new field with some initial-default value, but i think that have to wait for V3 table spec

gabeiglio avatar Feb 14 '25 20:02 gabeiglio

@Fokko could you rebase this when you get a chance

kevinjqliu avatar Apr 19 '25 18:04 kevinjqliu

@kevinjqliu Sure, but I think this relies on https://github.com/apache/iceberg-python/pull/1770 to do some proper testing 👍

Fokko avatar Apr 23 '25 06:04 Fokko