iceberg-python icon indicating copy to clipboard operation
iceberg-python copied to clipboard

Add clarifying docs to transform result types

Open kevinzwang opened this issue 1 year ago • 2 comments

Follow-up from #1208, documents the conclusions from the discussion.

kevinzwang avatar Sep 30 '24 22:09 kevinzwang

CI is failing due to dead loom link, removing here https://github.com/apache/iceberg-python/pull/1213

kevinjqliu avatar Oct 01 '24 16:10 kevinjqliu

@kevinjqliu @corleyma updated the doc strings! Let me know if there's any other changes I should make

kevinzwang avatar Oct 04 '24 19:10 kevinzwang

CI is blocked on #1213, i'll work to resolve it

kevinjqliu avatar Oct 05 '24 17:10 kevinjqliu

#1213 is merged, so the CI issue should be fixed @kevinzwang do you mind rebasing off main?

kevinjqliu avatar Oct 08 '24 00:10 kevinjqliu

@kevinjqliu oh I merged instead of rebase. Either way, I think it makes sense to squash and merge this PR into main anyway

kevinzwang avatar Oct 08 '24 19:10 kevinzwang

Also I don't think I have perms to merge myself so feel free to push the button whenever

kevinzwang avatar Oct 08 '24 22:10 kevinzwang

Merged! Thanks @kevinzwang for the contribution!

kevinjqliu avatar Oct 09 '24 14:10 kevinjqliu