iceberg-python icon indicating copy to clipboard operation
iceberg-python copied to clipboard

Remove `InMemoryCatalog` from the test-codebase

Open Fokko opened this issue 1 year ago • 2 comments

Feature Request / Improvement

InMemoryCatalog can be replaced by the SqlCatalog with Sqlite as a backend. Less code is more :)

Fokko avatar Aug 28 '24 19:08 Fokko

perhaps its a good idea to alias a new InMemoryCatalog implementation using SqlCatalog such as https://github.com/apache/iceberg-python/blob/9857107561d2267813b7ce150b01b4e6ac4b3e34/tests/catalog/test_sql.py#L113-L117

kevinjqliu avatar Sep 03 '24 21:09 kevinjqliu

@Fokko I agree with @kevinjqliu on the alias proposition, I implemented https://github.com/apache/iceberg-python/pull/1140 which makes InMemoryCatalog a subclass of SqlCatalog, and overrides some methods to simplify the tests.

hussein-awala avatar Sep 05 '24 22:09 hussein-awala