iceberg-go icon indicating copy to clipboard operation
iceberg-go copied to clipboard

test: add write operations test suite

Open Elbehery opened this issue 5 months ago • 6 comments

This PR adds test suite for write operations.

Inspired by TestRewriteFiles

cc @laskoviymishka

Elbehery avatar Jul 25 '25 08:07 Elbehery

Many of these types of tests already exist in table/table_test.go, can we move these tests there instead?

Go doesn't really have a convention of a "tests" directory like this, the tests should be in the same package as the code being tested.

zeroshade avatar Jul 25 '25 14:07 zeroshade

Many of these types of tests already exist in table/table_test.go, can we move these tests there instead?

Go doesn't really have a convention of a "tests" directory like this, the tests should be in the same package as the code being tested.

check now 👍🏽

Elbehery avatar Jul 25 '25 14:07 Elbehery

i fixed the linter issues, can u re-run plz

cc @zeroshade

Elbehery avatar Jul 25 '25 16:07 Elbehery

i ran golanglint run ./... but no error locally

Elbehery avatar Jul 25 '25 16:07 Elbehery

@zeroshade ptal :)

Elbehery avatar Jul 25 '25 16:07 Elbehery

@Elbehery see my comments :)

zeroshade avatar Jul 25 '25 17:07 zeroshade