table.doCommit call fails when metadata file is already removed

[jwtryg]

Apache Iceberg version

main (development)

Please describe the bug 🐞

When write.metadata.delete-after-commit.enabled is set to true, the deleteOldMetadata function will delete the old metadata files from the underlying fs. If this deletion fails, then the doCommit call will fail, even though the commit itself actually succeeded. This will happen fx. if a metadata file to be deleted has already been deleted by an external entity.

This problem occurs when using the Lakekeeper rest catalog implementation. Lakekeeper will also delete old metadata files when committing if write.metadata.delete-after-commit.enabled is set to true.

For reference, pyIceberg will simply log any failed delete. Should the goIceberg client maybe use the same approach?

I am happy to submit a PR to change this behaviour.

[zeroshade]

That seems like a reasonable solution!

I am happy to submit a PR to change this behaviour.

Please do! I'll happily review it