iceberg-go icon indicating copy to clipboard operation
iceberg-go copied to clipboard

--output json not supported?

Open knoguchi opened this issue 10 months ago • 5 comments

Apache Iceberg version

None

Please describe the bug 🐞

--output json prints "unimplemented output type". --output text works.

❯ iceberg --uri http://127.0.0.1:8181 --output json list
2025/03/05 20:42:34 unimplemented output type

~
❯ iceberg --uri http://127.0.0.1:8181 --output text list
┌───────────┐
| IDs       |
| --------- |
| taxitrips |
└───────────┘

https://github.com/apache/iceberg-go/blob/ba883bdb1d26cc8ea0505e3910ffee0f9c74f315/cmd/iceberg/main.go#L146-L149

Appers to be not implemented?

knoguchi avatar Mar 06 '25 04:03 knoguchi

@knoguchi can you please explaiin a bit more?

ArkVex avatar Mar 08 '25 06:03 ArkVex

Is the json output type planned but never implemented?

knoguchi avatar Mar 08 '25 08:03 knoguchi

I am here to contribute on this issue please explain this issue

ArkVex avatar Mar 08 '25 09:03 ArkVex

@knoguchi correct, it's planned but not yet implemented.

@ayush1009208 it would be great if could contribute an implementation of the json output 😄

zeroshade avatar Mar 08 '25 19:03 zeroshade

@zeroshade i will work on this issue

ArkVex avatar Mar 09 '25 06:03 ArkVex

@zeroshade @knoguchi

Implemented the json output format. Please review this pull request: https://github.com/apache/iceberg-go/pull/413

okhomin avatar May 01 '25 21:05 okhomin

looks like its implemented, thanks @okhomin !

kevinjqliu avatar May 06 '25 15:05 kevinjqliu