hudi icon indicating copy to clipboard operation
hudi copied to clipboard

Fix comment in RFC46

Open wzx140 opened this issue 1 year ago • 2 comments

Change Logs

Fix comments in rfc46. You can check all commits.

Impact

Describe any public API or user-facing feature change or any performance impact.

Risk level: none | low | medium | high

Choose one. If medium or high, explain what verification was done to mitigate the risks.

Contributor's checklist

  • [ ] Read through contributor's guide
  • [ ] Change Logs and Impact were stated clearly
  • [ ] Adequate tests were added if applicable
  • [ ] CI passed

wzx140 avatar Sep 22 '22 15:09 wzx140

@alexeykudinkin Could you please review it? Really thanks! Geng Xiaoyu and me have fix comments in RFC46. I found @DefaultSerializer(HoodieSparkRecordSerializer.class) and user need not to set spark.kryo.registrator.

wzx140 avatar Sep 22 '22 15:09 wzx140

https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=11609&view=results

wzx140 avatar Sep 23 '22 12:09 wzx140

@wzx140 can you please validate that @DefaultSerializer(HoodieSparkRecordSerializer.class) leads to HoodieSparkRecordSerializer being used by Kryo when shuffling?

alexeykudinkin avatar Sep 23 '22 18:09 alexeykudinkin

@wzx140 can you please validate that @DefaultSerializer(HoodieSparkRecordSerializer.class) leads to HoodieSparkRecordSerializer being used by Kryo when shuffling?

Yes. I check it in UT with printing some message in HoodieSparkRecordSerializer.

wzx140 avatar Sep 24 '22 15:09 wzx140

@hudi-bot run azure

wzx140 avatar Sep 25 '22 03:09 wzx140

@alexeykudinkin Please review the update when you have time.

wzx140 avatar Sep 26 '22 14:09 wzx140

@hudi-bot run azure

wzx140 avatar Oct 01 '22 09:10 wzx140

@alexeykudinkin I have implement without the Broadcast and schema inside HoodieSparkRecord and pass record's schema externally. Please review the update when you have time.

wzx140 avatar Oct 05 '22 16:10 wzx140

@hudi-bot run azure

wzx140 avatar Oct 05 '22 16:10 wzx140

CI fail with testReadFilterExistAfterBulkInsertPrepped. And it will fix after rebasing on master with commit HUDI-4923.

wzx140 avatar Oct 06 '22 07:10 wzx140

@hudi-bot run azure

wzx140 avatar Oct 06 '22 15:10 wzx140

@hudi-bot run azure

wzx140 avatar Oct 09 '22 05:10 wzx140

@hudi-bot run azure

wzx140 avatar Oct 14 '22 07:10 wzx140

CI report:

  • 0650eb40b10cf97c280809e89f351c15d1c2267f Azure: SUCCESS
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar Oct 14 '22 08:10 hudi-bot