hudi icon indicating copy to clipboard operation
hudi copied to clipboard

Published 20 hours ago • verified publisher icon apache

[HUDI-4780] Improve test setup

Open loukey-lj opened this issue 3 years ago • 3 comments

Change Logs

this pr supplements the 6602 test case. TestHoodieLogFormat initialization of fs is inconsistent with the actual running code, this is why the test code is as expected, but the log file is not segmented when actually running.

Impact

Correct the test code to align the test case with the actual running code

Contributor's checklist

  • [ ] Read through contributor's guide
  • [ ] Change Logs and Impact were stated clearly
  • [ ] Adequate tests were added if applicable
  • [ ] CI passed

loukey-lj avatar Sep 17 '22 06:09 loukey-lj

@loukey-lj does this add a test for #6602 (HUDI-4780)?

yes

loukey-lj avatar Sep 17 '22 11:09 loukey-lj

CI report:

  • d95e07d69ec781883f3b5f7fb511cc2e31fdddcf Azure: FAILURE
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar Sep 17 '22 13:09 hudi-bot

@xushiyan thank u,this pr supplements the 6602 test case. You can first look at the review record of 6602 .

loukey-lj avatar Sep 22 '22 02:09 loukey-lj

@loukey-lj : is this patch still valid ? can you respond to Ethan's and raymond's clarification above.

nsivabalan avatar Oct 19 '22 07:10 nsivabalan

On the latest master, the file system instance is already instantiated properly in the setup of TestHoodieLogFormat. Closing this PR. @loukey-lj feel free to reopen it when you see fit.

yihua avatar Mar 03 '24 23:03 yihua