hudi icon indicating copy to clipboard operation
hudi copied to clipboard

[HUDI-4488] Improve S3EventsHoodieIncrSource efficiency

Open vamshigv opened this issue 3 years ago • 5 comments

Tips

  • Thank you very much for contributing to Apache Hudi.
  • Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request

Improve S3 file listing efficiency by parallelizing the check by moving it from driver to executor.

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • [ ] Has a corresponding JIRA in PR title & commit

  • [ ] Commit message is descriptive of the change

  • [ ] CI is green

  • [ ] Necessary doc changes done or have another open PR

  • [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

vamshigv avatar Jul 27 '22 20:07 vamshigv

This is a small change that can have great impact on performance. Hence we would like to close this and land this first while we iterate on https://github.com/apache/hudi/pull/6176

vamshigv avatar Jul 27 '22 21:07 vamshigv

@hudi-bot run azure

vamshigv avatar Aug 02 '22 23:08 vamshigv

@vamshigv IT needs some investigation (from local setup), probably not flakiness.

xushiyan avatar Aug 03 '22 21:08 xushiyan

@hudi-bot run azure

vamshigv avatar Aug 11 '22 04:08 vamshigv

CI report:

  • 0f7c3d5002dd2d5bd65bba2768766769ef0f5466 Azure: SUCCESS
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar Aug 11 '22 06:08 hudi-bot