hudi icon indicating copy to clipboard operation
hudi copied to clipboard

[HUDI-1575][RFC-56] Early Conflict Detection For Multi-writer

Open zhangyue19921010 opened this issue 3 years ago • 2 comments
trafficstars

Tips

  • Thank you very much for contributing to Apache Hudi.
  • Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • [ ] Has a corresponding JIRA in PR title & commit

  • [ ] Commit message is descriptive of the change

  • [ ] CI is green

  • [ ] Necessary doc changes done or have another open PR

  • [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

zhangyue19921010 avatar Jun 29 '22 08:06 zhangyue19921010

@hudi-bot run azure

zhangyue19921010 avatar Jul 04 '22 10:07 zhangyue19921010

CI report:

  • 6069fdcfd9fa1e76d33d786ebd2f40f982eb85e5 Azure: FAILURE
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar Jul 04 '22 10:07 hudi-bot

@prasannarajaperumal could you take another look at this RFC before we merge it? I'm going to move on to reviewing the implementation in #6133 .

yihua avatar Sep 29 '22 20:09 yihua

Hi @yihua and @pratyakshsharma . Really appreciate for your attention here! Address the comments. PTAL :)

zhangyue19921010 avatar Oct 03 '22 03:10 zhangyue19921010

@zhangyue19921010 Thanks for addressing the comments. Why are some code changes involved? Could you properly rebase this PR on the latest master?

ooooh. Sorry for that. Just rebased the master branch. PTAL

zhangyue19921010 avatar Oct 05 '22 11:10 zhangyue19921010

Thanks all for your efforts here!

zhangyue19921010 avatar Oct 14 '22 10:10 zhangyue19921010