hudi icon indicating copy to clipboard operation
hudi copied to clipboard

[HUDI-4284] Implement bloom lookup tree as red-black tree

Open yabola opened this issue 3 years ago • 5 comments

What is the purpose of the pull request

The existing KeyRangeLookupTree implementation is Binary Sorting Tree. Although it is shuffled before insertion, it may still cause uneven distribution. This PR implement it as a Red Black Tree.

Brief change log

Added abstract implementation of red-black tree RedBlackTree and implement the KeyRangeLookupTree as red-black tree.

Verify this pull request

Added new unit test org.apache.hudi.common.util.rbtree.TestRedBlackTree

Committer checklist

  • [x] Has a corresponding JIRA in PR title & commit

  • [x] Commit message is descriptive of the change

  • [x] CI is green

  • [x] Necessary doc changes done or have another open PR

  • [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

yabola avatar Jun 26 '22 12:06 yabola

@codope @nsivabalan Please take a look~

yabola avatar Jul 01 '22 05:07 yabola

@vinothchandar Can you help review this PR, thanks.

yabola avatar Aug 03 '22 02:08 yabola

@yabola Thanks for putting up this PR. Sorry for the delay as I was occupied with Hudi release work. I am going to review it towards the end of week. Expect feedback by Monday.

codope avatar Aug 10 '22 10:08 codope

@yihua @codope Hi, if you have time, can you help review my PR, thanks~

yabola avatar Oct 25 '22 16:10 yabola

CI report:

  • 1598d995433bd8f85b1d6b6b0bd9b0a76cae37b7 Azure: SUCCESS
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar Oct 27 '22 00:10 hudi-bot