hudi icon indicating copy to clipboard operation
hudi copied to clipboard

Published 20 hours ago • verified publisher icon apache

[DO NOT MERGE][HUDI-2624] Implement Non Index type for HUDI

Open yuzhaojing opened this issue 3 years ago • 16 comments

Tips

  • Thank you very much for contributing to Apache Hudi.
  • Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • [ ] Has a corresponding JIRA in PR title & commit

  • [ ] Commit message is descriptive of the change

  • [ ] CI is green

  • [ ] Necessary doc changes done or have another open PR

  • [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

yuzhaojing avatar Oct 29 '21 07:10 yuzhaojing

@yuzhaojing check CI?

yanghua avatar Oct 29 '21 11:10 yanghua

@hudi-bot run azure

yuzhaojing avatar Oct 29 '21 11:10 yuzhaojing

@hudi-bot run azure

yuzhaojing avatar Oct 30 '21 02:10 yuzhaojing

@hudi-bot run azure

yuzhaojing avatar Nov 01 '21 03:11 yuzhaojing

@hudi-bot run azure

yuzhaojing avatar Nov 03 '21 01:11 yuzhaojing

@hudi-bot run azure

yuzhaojing avatar Nov 03 '21 01:11 yuzhaojing

@yuzhaojing check CI?

CI is all successed.

yuzhaojing avatar Nov 03 '21 05:11 yuzhaojing

@hudi-bot run azure

yuzhaojing avatar Nov 10 '21 07:11 yuzhaojing

@yuzhaojing have a quick look, left some comments.

Thanks for your comments, already fix that.

yuzhaojing avatar Nov 15 '21 02:11 yuzhaojing

Hi @yanghua , I've fixed all comments, only NO_INDEX I think is not a better name, like NonpartitionedKeyGenerator.

yuzhaojing avatar Nov 18 '21 08:11 yuzhaojing

Hi @yanghua , I've fixed all comments, only NO_INDEX I think is not a better name, like NonpartitionedKeyGenerator.

OK, reasonable.

yanghua avatar Nov 18 '21 11:11 yanghua

Have a long holiday, will back to another check soon.

yanghua avatar Dec 03 '21 06:12 yanghua

@garyli1019 @danny0405 Would you like to have a double-check?

yanghua avatar Dec 14 '21 03:12 yanghua

@yanghua Do not merge before i check it.

danny0405 avatar Dec 14 '21 03:12 danny0405

CI report:

  • 326ba7955e42fd1fae3e8c746e6a9ee04d73ef54 UNKNOWN
  • 7b72fb821b3bde604b9301eb2fe071440f7b12d3 Azure: FAILURE
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar Aug 10 '22 10:08 hudi-bot

LGTM

XuQianJin-Stars avatar Sep 23 '22 01:09 XuQianJin-Stars