hudi icon indicating copy to clipboard operation
hudi copied to clipboard

[HUDI-7940] Pass HoodieIngestionMetrics to Error Table Writer to be able to emit metrics for Error Table Writer

Open rmahindra123 opened this issue 1 year ago • 2 comments

Change Logs

Pass HoodieIngestionMetrics to Error Table Writer, keep support for old interface for ErrorTableWriter.

Impact

Pass HoodieIngestionMetrics to Error Table Writer to be able to emit metrics for Error Table Wrier.

Risk level (write none, low medium or high below)

Low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the ticket number here and follow the instruction to make changes to the website.

Contributor's checklist

  • [ ] Read through contributor's guide
  • [ ] Change Logs and Impact were stated clearly
  • [ ] Adequate tests were added if applicable
  • [ ] CI passed

rmahindra123 avatar Jun 29 '24 08:06 rmahindra123

LGTM in general, could you fix the checkstyle issue as well?

src/main/java/org/apache/hudi/utilities/streamer/ErrorTableUtils.java:[38,8] (imports) UnusedImports: Unused import - java.lang.reflect.InvocationTargetException.

cc: @yihua

CTTY avatar Jul 02 '24 22:07 CTTY

CI report:

  • 85a2070ee1dd4f07aa23f9b7ed17b7f81c5f9f53 Azure: SUCCESS
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar Sep 18 '24 23:09 hudi-bot